nastra commented on code in PR #6948: URL: https://github.com/apache/iceberg/pull/6948#discussion_r1425557919
########## core/src/main/java/org/apache/iceberg/catalog/CatalogTransaction.java: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.catalog; + +public interface CatalogTransaction { + + enum IsolationLevel { + + /** + * All reads that are being made will see the last committed values that existed when the table Review Comment: Sorry for my late reply on this topic. The current implementation does perform **option 2**, where it detects that read data hasn't been changed. This is being done for `snapshot` as well as `serializable` isolation. The only difference between `snapshot` and `serializable` isolation in the current implementation is that `serializable` also detects and avoids `write skew`. @jackye1995 did you have a chance to look at the implementation and the tests or is the definition of `snapshot` isolation confusing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
