nastra commented on code in PR #9282:
URL: https://github.com/apache/iceberg/pull/9282#discussion_r1423827359
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveCreateReplaceTableTest.java:
##########
@@ -60,8 +66,23 @@ public class HiveCreateReplaceTableTest extends
HiveMetastoreTest {
private String tableLocation;
+ @RegisterExtension
+ private static final HiveMetastoreExtension HIVE_METASTORE_EXTENSION =
+ new HiveMetastoreExtension(DB_NAME, Collections.emptyMap());
+
+ private HiveCatalog catalog;
+
@BeforeEach
public void createTableLocation() throws IOException {
+ catalog =
Review Comment:
> Also can we move this to `HiveMetastoreExtension` and get the catalog from
there? It can help in duplicating this code in each test class which uses this
extension.
I don't think the catalog initialization should be moved into
`HiveMetastoreExtension`. The sole purpose of `HiveMetastoreExtension` is to
provide the metastore part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
