nastra commented on code in PR #9161:
URL: https://github.com/apache/iceberg/pull/9161#discussion_r1423607969
##########
data/src/test/java/org/apache/iceberg/data/GenericAppenderHelper.java:
##########
@@ -43,18 +45,28 @@ public class GenericAppenderHelper {
private final Table table;
private final FileFormat fileFormat;
- private final TemporaryFolder tmp;
+ private final Path tmp;
private final Configuration conf;
+ @Deprecated()
public GenericAppenderHelper(
- Table table, FileFormat fileFormat, TemporaryFolder tmp, Configuration
conf) {
+ Table table, FileFormat fileFormat, TemporaryFolder tmp, Configuration
conf)
Review Comment:
let's roll back these changes and focus only on adding the
`ParameterizedTestExtension` and converting `TestDictRowGroupFilter´
##########
data/src/test/java/org/apache/iceberg/data/GenericAppenderHelper.java:
##########
@@ -43,18 +45,28 @@ public class GenericAppenderHelper {
private final Table table;
private final FileFormat fileFormat;
- private final TemporaryFolder tmp;
+ private final Path tmp;
private final Configuration conf;
+ @Deprecated()
public GenericAppenderHelper(
- Table table, FileFormat fileFormat, TemporaryFolder tmp, Configuration
conf) {
+ Table table, FileFormat fileFormat, TemporaryFolder tmp, Configuration
conf)
Review Comment:
let's roll back these changes and focus only on adding the
`ParameterizedTestExtension` and converting `TestDictRowGroupFilter´
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
