amogh-jahagirdar commented on code in PR #9274:
URL: https://github.com/apache/iceberg/pull/9274#discussion_r1423322127
##########
data/src/main/java/org/apache/iceberg/data/TableMigrationUtil.java:
##########
@@ -215,11 +215,11 @@ private static DataFile buildDataFile(
.build();
}
- private static ExecutorService migrationService(int concurrentDeletes) {
+ private static ExecutorService migrationService(int numThreads) {
Review Comment:
Ah you are right. I confused myself, in that case this name is a good thing.
Thanks for fixing this!
##########
data/src/main/java/org/apache/iceberg/data/TableMigrationUtil.java:
##########
@@ -215,11 +215,11 @@ private static DataFile buildDataFile(
.build();
}
- private static ExecutorService migrationService(int concurrentDeletes) {
+ private static ExecutorService migrationService(int numThreads) {
Review Comment:
Ah you are right. I confused myself, in that case this name change is a good
change. Thanks for fixing this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
