HonahX commented on code in PR #194:
URL: https://github.com/apache/iceberg-python/pull/194#discussion_r1421197076
##########
mkdocs/docs/api.md:
##########
@@ -33,6 +33,20 @@ catalog:
credential: t-1234:secret
```
+Note that multiple catalogs can be defined in the same `.pyiceberg.yaml`:
+```yaml
+catalog:
+ hive:
+ uri: thrift://127.0.0.1:9083
+ s3.endpoint: http://127.0.0.1:9000
+ s3.access-key-id: admin
+ s3.secret-access-key: password
+ rest:
+ uri: https://rest-server:8181/
+ warehouse: my-warehouse
+```
+and loaded in python by calling `load_catalog`. See below for an example.
Review Comment:
I think the example primarily illustrates how to load a catalog that is not
defined in `.pyiceberg.yaml`. For catalogs that are defined in the yaml file,
we might say
```
and loaded in python by calling `load_catalog(name="hive")` and
`load_catalog(name="rest")`
```
Does this sound right to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
