amogh-jahagirdar commented on code in PR #9247:
URL: https://github.com/apache/iceberg/pull/9247#discussion_r1419760735
##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -200,6 +200,13 @@ public void completeCreateView() {
.build())
.build());
+ assertThat(((SQLViewRepresentation) view.sqlFor("spark")).sql())
+ .isEqualTo("select * from ns.tbl");
+ assertThat(((SQLViewRepresentation) view.sqlFor("trino")).sql())
+ .isEqualTo("select * from ns.tbl using X");
+ assertThat(((SQLViewRepresentation) view.sqlFor("unknown-dialect")).sql())
+ .isEqualTo("select * from ns.tbl using X");
Review Comment:
I should add a test where a non "sql" representation is added, to verify
null is returned when there is no sql representation. Our APIs don't really
expose that anyways because we don't have a notion of a "non-sql"
representation yet but worth testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
