cgpoh commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1418251955
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java:
##########
@@ -483,7 +473,7 @@ private static void assertArrayValues(
private static void assertMapValues(
Types.MapType mapType, LogicalType type, Map<?, ?> expected, MapData
actual) {
- Assert.assertEquals("map size should be equal", expected.size(),
actual.size());
+ assertThat(actual.size()).as("map size should be
equal").isEqualTo(expected.size());
Review Comment:
@nastra , I have problem using `hasSameSizeAs(...)` here as MapData is not
extending from `Collection`, `assertThat` has difficulty inferring that
`actual` can be enumerated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
