Fokko commented on issue #184:
URL: https://github.com/apache/iceberg-python/issues/184#issuecomment-1842280596

   Hey @cosmastech Thanks for chiming in here! 
   
   The confusion here is between the Iceberg tables in general and the tables 
used by the SqlCatalog (which uses Alembic). We don't want to auto-create any 
Iceberg tables.
   
   When you create a new SqlCatalog, there will be no tables in which to store 
the catalog information. This means that it is specific to the SqlCatalog, and 
we don't need to create any abstract methods. When initializing a SqlCatalog, 
we want to fire a query just to check if the two tables 
([`iceberg_namespace_properties`](https://github.com/apache/iceberg-python/blob/34b18e4b7b3d7d44e90a7b6ae266ad026da26150/pyiceberg/catalog/sql.py#L83)
 and 
[`iceberg_tables`](https://github.com/apache/iceberg-python/blob/main/pyiceberg/catalog/sql.py#L73C22-L73C36)).
 Does this help?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to