amogh-jahagirdar commented on PR #9223: URL: https://github.com/apache/iceberg/pull/9223#issuecomment-1841356581
Thanks @bartash . I think let's get https://github.com/apache/iceberg/pull/9221 in first and then we can rebase this change? The change for returning a new empty set was not just stylistic, it was intentional to distinguish the case where deletion can be performed (empty snapshot list from expire snapshots in a transaction) and where deletion should not be performed if we could not determine the files to delete (snapshot lookup failed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
