amogh-jahagirdar opened a new pull request, #9221: URL: https://github.com/apache/iceberg/pull/9221
This is a follow up to https://github.com/apache/iceberg/pull/9183. Null gets returned from `committedFiles` in 2 cases: 1.) The snapshot ID list is empty. This snapshot ID is the set of snapshots produced as a result of the transaction 2.).The set of committed files could not exactly be determined (e.g. missing any snapshot metadata). In the first case, the logic should perform cleanup in case there were no new snapshots (e.g. ExpireSnapshots) which #9183 pointed out and addressed. In the second case, we do want to signal to callers that it's a unique situation and file deletions should not be performed. What this change does is return an empty set in case 1 and null in case 2 to prevent deleting files when we could not determine the full set of committed files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
