amogh-jahagirdar opened a new pull request, #9196: URL: https://github.com/apache/iceberg/pull/9196
Fixes #8849 This change adds a `fastForwardOrCreate` API which will perform a fast forward of the `from` branch if it exists; otherwise `from` will be created and pointing towards what `to` references. This change also integrates the API with the Spark fast forward procedure by default. Technically this is a behavior change but I think it is arguable that the previous behavior was a bug/incorrect behavior so we should change that. Alternatives to this include: 1.) no new API, do a try/catch of fast forward and in case it fails attempt to do a creation. I think the issue there beyond being a little messy is that it forces clients/integrations to have that everywhere. 2.) No new API, Change the `fastForward` API behavior to do a creation by default. I can see the merit because ultimately I think it would be quite common for users to frequently fast forward a branch which does not exist before. But I ultimately don't want to set a precedent on API behavior changes. I concluded on a new API because at this point, users who would be using the fast forward API would've already had to create the branch anyways; a new API allows existing users to simplify their code, and new users to just use the new API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
