Fokko commented on code in PR #139:
URL: https://github.com/apache/iceberg-python/pull/139#discussion_r1409336199
##########
pyiceberg/table/__init__.py:
##########
@@ -350,6 +357,241 @@ class RemovePropertiesUpdate(TableUpdate):
removals: List[str]
+class TableMetadataUpdateContext:
+ updates: List[TableUpdate]
+ last_added_schema_id: Optional[int]
Review Comment:
I prefer to keep them separate. I think we might need to have some
additional checks here such as, what happens if you add a column, and then
revoke the column again. It will first create a new schema, with a new ID, and
then it will reuse the old schema again.
- 1: Schema(a: int), current_schema_id=1
Add column b:
- 1: Schema(a: int), 2: Schema(a: int, b: int), current_schema_id=2
Drop column b:
- 1: Schema(a: int), 2: Schema(a: int, b: int), current_schema_id=1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
