pvary commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405869289
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -186,6 +190,10 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
if (tbl != null) {
// If we try to create the table but the metadata location is already
set, then we had a
// concurrent commit
+ if
(tbl.getTableType().equalsIgnoreCase(TableType.VIRTUAL_VIEW.name())) {
+ throw new AlreadyExistsException(
+ "View with same name already exists: %s.%s", tbl.getDbName(),
tbl.getTableName());
+ }
Review Comment:
Should we put this code before the comment?
The comment is for the next line below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
