pvary commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405831314
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -234,15 +225,25 @@ public void renameTable(TableIdentifier from,
TableIdentifier originalTo) {
String fromName = from.name();
try {
- Table table = clients.run(client -> client.getTable(fromDatabase,
fromName));
- HiveOperationsBase.validateTableIsIceberg(table, fullTableName(name,
from));
-
- table.setDbName(toDatabase);
- table.setTableName(to.name());
+ Table fromTable = clients.run(client -> client.getTable(fromDatabase,
fromName));
+ HiveOperationsBase.validateTableIsIceberg(fromTable, fullTableName(name,
from));
+ Optional<Table> toTable =
+ HiveCatalogUtil.loadHmsTableIfPresent(clients, toDatabase,
to.name());
+ if (toTable.isPresent()) {
+ if
(toTable.get().getTableType().equalsIgnoreCase(TableType.VIRTUAL_VIEW.name())) {
Review Comment:
Question: Would this be this be easier to read?
```
if (toTable.isPresent()) {
TableType type = toTable.get().getTableType();
throw new org.apache.iceberg.exceptions.AlreadyExistsException(
"Cannot rename %s to %s. %s already exists",
from,
to,
type.equalsIgnoreCase(TableType.VIRTUAL_VIEW.name()) ? "View" :
"Table");
}
```
Nothing you must change, but seems a bit more natural to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
