nastra commented on code in PR #9048:
URL: https://github.com/apache/iceberg/pull/9048#discussion_r1401887508
##########
build.gradle:
##########
@@ -948,6 +948,48 @@ project(':iceberg-snowflake') {
}
}
+project(':iceberg-tencentcloud') {
+ test {
+ useJUnitPlatform()
+ }
+
+ dependencies {
+ implementation project(path: ':iceberg-bundled-guava', configuration:
'shadow')
+ api project(':iceberg-api')
+ implementation project(':iceberg-core')
+ implementation project(':iceberg-common')
+
+ compileOnly (libs.cos.sdk) {
+ exclude group: 'com.google.code.gson', module: 'gson'
+ }
+ compileOnly (libs.cos.sdk.bundle) {
+ exclude group: 'com.google.code.gson', module: 'gson'
+ }
+ compileOnly libs.jaxb.api
Review Comment:
are these required? I see that they have been copy/pasted from the
`':iceberg-aliyun'` module would I'd suggest to slim this down to what is
required for this project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
