pvary commented on PR #9120: URL: https://github.com/apache/iceberg/pull/9120#issuecomment-1820705097
@cgpoh: We usually only create a PR for a single version of Flink (latest). After that PR is merged, then we create a backport PR to get the changes to the older versions. This helps the reviewer (smaller number of changes), and the contributor (if changes was requested then it is a smaller work) too. Please avoid having the J5 in the class names - we would like to remove the old classes, and after that J5 classes will be hard to understand. Create a new package? Find a better name for the classes? Whatever works - but keep in mind the goal 😄 Please migrate at least one test class to the new base package, so we can try things out. I have found that `TemporaryFolder`, `GenericAppenderHelper` should be migrated too to have a full Junit5 test infra. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
