amogh-jahagirdar commented on code in PR #9102:
URL: https://github.com/apache/iceberg/pull/9102#discussion_r1398013059
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java:
##########
@@ -326,9 +326,8 @@ public void testDeleteWithoutScanningTable() throws
Exception {
public void testDeleteFileThenMetadataDelete() throws Exception {
Assume.assumeFalse("Avro does not support metadata delete",
fileFormat.equals("avro"));
createAndInitUnpartitionedTable();
-
- sql("INSERT INTO TABLE %s VALUES (1, 'hr'), (2, 'hardware'), (null,
'hr')", tableName);
createBranchIfNeeded();
+ sql("INSERT INTO TABLE %s VALUES (1, 'hr'), (2, 'hardware'), (null,
'hr')", commitTarget());
Review Comment:
I reordered this since for the purpose of this test we want all the writes
to happen on a single branch. Without the fix, this test will fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]