aokolnychyi commented on code in PR #8970:
URL: https://github.com/apache/iceberg/pull/8970#discussion_r1395060541
##########
core/src/main/java/org/apache/iceberg/DataFiles.java:
##########
@@ -301,12 +299,10 @@ public Builder withSplitOffsets(List<Long> offsets) {
return this;
}
+ /** @deprecated since 1.5.0, will be removed in 1.6.0; must not be set for
data files. */
+ @Deprecated
public Builder withEqualityFieldIds(List<Integer> equalityIds) {
- if (equalityIds != null) {
- this.equalityFieldIds = ImmutableList.copyOf(equalityIds);
- }
-
- return this;
+ throw new UnsupportedOperationException("Equality field IDs must not be
set for data files");
Review Comment:
Actually, IntelliJ starts to warn that the deprecated method is being used.
We also don't have a good suite for the data file builder. Adding a new suite
is probably not worth the effort. I'd skip it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
