nk1506 commented on code in PR #9063:
URL: https://github.com/apache/iceberg/pull/9063#discussion_r1393126118
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java:
##########
@@ -108,6 +110,110 @@ public ParquetValueReader<?> struct(
}
}
+ private class LogicalTypeAnnotationParquetValueReaderVisitor
+ implements
LogicalTypeAnnotation.LogicalTypeAnnotationVisitor<ParquetValueReader<?>> {
+
+ private final ColumnDescriptor desc;
+ private final org.apache.iceberg.types.Type.PrimitiveType expected;
+ private final PrimitiveType primitive;
+
+ LogicalTypeAnnotationParquetValueReaderVisitor(
+ ColumnDescriptor desc,
+ org.apache.iceberg.types.Type.PrimitiveType expected,
+ PrimitiveType primitive) {
+ this.desc = desc;
+ this.expected = expected;
+ this.primitive = primitive;
+ }
+
+ @Override
+ public Optional<ParquetValueReader<?>> visit(
Review Comment:
is this `case UTF8:
return new ParquetValueReaders.StringReader(desc);` being
covered here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
