aokolnychyi commented on code in PR #9069: URL: https://github.com/apache/iceberg/pull/9069#discussion_r1393062719
########## core/src/main/java/org/apache/iceberg/actions/SizeBasedFileRewriter.java: ########## @@ -101,8 +101,6 @@ public abstract class SizeBasedFileRewriter<T extends ContentScanTask<F>, F exte public static final long MAX_FILE_GROUP_SIZE_BYTES_DEFAULT = 100L * 1024 * 1024 * 1024; // 100 GB - private static final long SPLIT_OVERHEAD = 5 * 1024; Review Comment: This split overhead did very little given that it is only 5 KB. Row group size discrepancies are usually a few megabytes. I will have a follow-up PR to make our split planning less sensitive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
