nastra commented on code in PR #9061:
URL: https://github.com/apache/iceberg/pull/9061#discussion_r1392616478
##########
gcp/src/main/java/org/apache/iceberg/gcp/GCPProperties.java:
##########
@@ -90,6 +95,10 @@ public GCPProperties(Map<String, String> properties) {
gcsOAuth2TokenExpiresAt =
new
Date(Long.parseLong(properties.get(GCS_OAUTH2_TOKEN_EXPIRES_AT)));
}
+ gcsNoAuth = Boolean.parseBoolean(properties.getOrDefault(GCS_NO_AUTH,
"false"));
+ Preconditions.checkState(
Review Comment:
it would be good to also have a test that specifically checks that you can
only set one of these
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
