nastra commented on code in PR #8966: URL: https://github.com/apache/iceberg/pull/8966#discussion_r1389276940
########## format/view-spec.md: ########## @@ -239,12 +239,14 @@ s3://bucket/warehouse/default.db/event_agg/metadata/00001-(uuid).metadata.json ``` Each change creates a new metadata JSON file. +For example, SQL is modified with identifier having catalog name and namespace as below. ```sql USE prod.other_db; CREATE OR REPLACE VIEW default.event_agg ( - event_count, + event_count COMMENT 'Count of events', Review Comment: I think it would be better to just remove the comment(s) in general from here and from the JSON -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
