aokolnychyi commented on code in PR #9020:
URL: https://github.com/apache/iceberg/pull/9020#discussion_r1388791747
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##########
@@ -264,14 +293,15 @@ private <T, U> U withReusableDS(Dataset<T> ds,
Function<Dataset<T>, U> func) {
}
}
- private List<ManifestFile> findMatchingManifests() {
+ private List<ManifestFile> findMatchingManifests(ManifestContent content) {
Snapshot currentSnapshot = table.currentSnapshot();
if (currentSnapshot == null) {
return ImmutableList.of();
}
- return currentSnapshot.dataManifests(table.io()).stream()
+ return currentSnapshot.allManifests(table.io()).stream()
+ .filter(manifest -> manifest.content() == content)
Review Comment:
I kept it separate to avoid Spotless formatting the closure in a weird way.
I can define a method and call it here. These filters are chained together
prior to execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
