jacobmarble commented on PR #9008:
URL: https://github.com/apache/iceberg/pull/9008#issuecomment-1802578562

   Do these need to be addressed in this PR?
   
   ```console
   TestSpark3Util > testDescribeSortOrder FAILED
       org.junit.ComparisonFailure: Sort order isn't correct. 
expected:<[hours(time) DESC NULLS FIRST]> but was:<[]>
           at org.junit.Assert.assertEquals(Assert.java:117)
           at 
org.apache.iceberg.spark.TestSpark3Util.testDescribeSortOrder(TestSpark3Util.java:84)
   
   TestFilteredScan > [format = parquet, vectorized = false, planningMode = 
LOCAL] > testHourPartitionedTimestampFilters[format = parquet, vectorized = 
false, planningMode = LOCAL] FAILED
       java.lang.AssertionError: Primitive value should be equal to expected 
expected:<8> but was:<5>
           at org.junit.Assert.fail(Assert.java:89)
           at org.junit.Assert.failNotEquals(Assert.java:835)
           at org.junit.Assert.assertEquals(Assert.java:120)
           at 
org.apache.iceberg.spark.data.GenericsHelpers.assertEqualsSafe(GenericsHelpers.java:119)
           at 
org.apache.iceberg.spark.data.GenericsHelpers.assertEqualsSafe(GenericsHelpers.java:68)
           at 
org.apache.iceberg.spark.source.TestFilteredScan.assertEqualsSafe(TestFilteredScan.java:573)
           at 
org.apache.iceberg.spark.source.TestFilteredScan.testHourPartitionedTimestampFilters(TestFilteredScan.java:374)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to