lirui-apache commented on PR #4732: URL: https://github.com/apache/iceberg/pull/4732#issuecomment-1800965092
Hey guys, I have some questions about the API change here. 1. Do we need to differentiate the case when default value is not specified, and the case when default value is explicitly set to null? I guess it won't be necessary for optional columns, but not sure about required columns. 2. NestedField is a `Serializable`. So I think we need to make sure the default value objects, e.g. `StructLike`, are also serializables right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org