jacobmarble commented on code in PR #8971: URL: https://github.com/apache/iceberg/pull/8971#discussion_r1385434928
########## format/spec.md: ########## Review Comment: > Don't the Avro and Parquet details need to be updated? Yes. (I'm new to the project.) My original intent here was to create multiple PRs, each with a different scope (API/Core, Avro, ORC, Parquet, Spark/Flink/Hive/etc). However, the cascade of failing tests in this PR suggests that one big change might be necessary. Do you have any feedback on this? > are these changes intended to be backdate into spec version 1 and 2 or part of v3? These changes affect v3 only. https://github.com/apache/iceberg/blob/7c4bdaa3a26f2a8b36f22b1a1257aa11bf136969/format/spec.md?plain=1#L184-L185 https://github.com/apache/iceberg/blob/7c4bdaa3a26f2a8b36f22b1a1257aa11bf136969/format/spec.md?plain=1#L1302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
