pvary commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1384694865
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -264,6 +251,146 @@ public void renameTable(TableIdentifier from,
TableIdentifier originalTo) {
}
}
+ @Override
+ public boolean viewExists(TableIdentifier identifier) {
+ return HiveCatalogUtil.isTableWithTypeExists(clients, identifier,
TableType.VIRTUAL_VIEW);
+ }
+
+ @Override
+ public boolean dropView(TableIdentifier identifier) {
+ if (!isValidIdentifier(identifier)) {
+ return false;
+ }
+ try {
+ String database = identifier.namespace().level(0);
+ String viewName = identifier.name();
+ Table table = clients.run(client -> client.getTable(database, viewName));
+ HiveCatalogUtil.validateTableIsIcebergView(table, fullTableName(name,
identifier));
+ clients.run(
+ client -> {
+ client.dropTable(database, viewName);
+ return null;
+ });
+ LOG.info("Dropped View: {}", identifier);
+ return true;
+
+ } catch (NoSuchViewException | NoSuchObjectException e) {
+ LOG.info("Skipping drop, View does not exist: {}", identifier, e);
+ return false;
+ } catch (TException e) {
+ throw new RuntimeException("Failed to drop " + identifier, e);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ throw new RuntimeException("Interrupted in call to dropView", e);
+ }
+ }
+
+ @Override
+ public List<TableIdentifier> listViews(Namespace namespace) {
+ try {
+ return listContents(namespace, TableType.VIRTUAL_VIEW.name(),
icebergPredicate());
+ } catch (UnknownDBException e) {
+ throw new NoSuchNamespaceException("Namespace does not exist: %s",
namespace);
+
+ } catch (TException e) {
+ throw new RuntimeException("Failed to list all views under namespace " +
namespace, e);
+
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ throw new RuntimeException("Interrupted in call to listViews", e);
+ }
+ }
+
+ private List<TableIdentifier> listContents(
+ Namespace namespace, String tableType, Predicate<Table> tablePredicate)
+ throws TException, InterruptedException {
+ Preconditions.checkArgument(
+ isValidateNamespace(namespace), "Missing database in namespace: %s",
namespace);
+ String database = namespace.level(0);
+ List<String> tableNames =
+ StringUtils.isNotEmpty(tableType)
+ ? clients.run(client -> client.getTables(database, "*",
TableType.valueOf(tableType)))
+ : clients.run(client -> client.getAllTables(database));
+ List<Table> tableObjects =
+ clients.run(client -> client.getTableObjectsByName(database,
tableNames));
Review Comment:
When we were optimizing for performance, every extra HMS call is
problematic. I would prefer a solution, where we do not call the HMS if it is
not neccessary
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -264,6 +251,146 @@ public void renameTable(TableIdentifier from,
TableIdentifier originalTo) {
}
}
+ @Override
+ public boolean viewExists(TableIdentifier identifier) {
+ return HiveCatalogUtil.isTableWithTypeExists(clients, identifier,
TableType.VIRTUAL_VIEW);
+ }
+
+ @Override
+ public boolean dropView(TableIdentifier identifier) {
+ if (!isValidIdentifier(identifier)) {
+ return false;
+ }
+ try {
+ String database = identifier.namespace().level(0);
+ String viewName = identifier.name();
+ Table table = clients.run(client -> client.getTable(database, viewName));
+ HiveCatalogUtil.validateTableIsIcebergView(table, fullTableName(name,
identifier));
+ clients.run(
+ client -> {
+ client.dropTable(database, viewName);
+ return null;
+ });
+ LOG.info("Dropped View: {}", identifier);
+ return true;
+
+ } catch (NoSuchViewException | NoSuchObjectException e) {
+ LOG.info("Skipping drop, View does not exist: {}", identifier, e);
+ return false;
+ } catch (TException e) {
+ throw new RuntimeException("Failed to drop " + identifier, e);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ throw new RuntimeException("Interrupted in call to dropView", e);
+ }
+ }
+
+ @Override
+ public List<TableIdentifier> listViews(Namespace namespace) {
+ try {
+ return listContents(namespace, TableType.VIRTUAL_VIEW.name(),
icebergPredicate());
+ } catch (UnknownDBException e) {
+ throw new NoSuchNamespaceException("Namespace does not exist: %s",
namespace);
+
+ } catch (TException e) {
+ throw new RuntimeException("Failed to list all views under namespace " +
namespace, e);
+
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ throw new RuntimeException("Interrupted in call to listViews", e);
+ }
+ }
+
+ private List<TableIdentifier> listContents(
+ Namespace namespace, String tableType, Predicate<Table> tablePredicate)
+ throws TException, InterruptedException {
+ Preconditions.checkArgument(
+ isValidateNamespace(namespace), "Missing database in namespace: %s",
namespace);
+ String database = namespace.level(0);
+ List<String> tableNames =
+ StringUtils.isNotEmpty(tableType)
+ ? clients.run(client -> client.getTables(database, "*",
TableType.valueOf(tableType)))
+ : clients.run(client -> client.getAllTables(database));
+ List<Table> tableObjects =
+ clients.run(client -> client.getTableObjectsByName(database,
tableNames));
Review Comment:
When we were optimizing for performance, every extra HMS call is
problematic. I would prefer a solution, where we do not call the HMS if it is
not necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
