aokolnychyi commented on code in PR #8972:
URL: https://github.com/apache/iceberg/pull/8972#discussion_r1380715154
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##########
@@ -307,8 +268,16 @@ private int targetNumManifests(long totalSizeBytes) {
return (int) ((totalSizeBytes + targetManifestSizeBytes - 1) /
targetManifestSizeBytes);
}
- private int targetNumManifestEntries(int numEntries, int numManifests) {
- return (numEntries + numManifests - 1) / numManifests;
+ private long totalSizeBytes(Iterable<ManifestFile> manifests) {
+ long totalSizeBytes = 0L;
+
+ for (ManifestFile manifest : manifests) {
+ ValidationException.check(
Review Comment:
I copied the existing check. I believe those fields are optional and return
`Long` (it may be true for some very old versions of Iceberg, not now).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
