ajantha-bhat commented on code in PR #8500: URL: https://github.com/apache/iceberg/pull/8500#discussion_r1380176383
########## api/src/test/java/org/apache/iceberg/TestHelpers.java: ########## @@ -265,6 +266,18 @@ public static void serialize(final Serializable obj, final OutputStream outputSt } } + public static void assertThrows( Review Comment: Needed for the testcase moved from parquet module as I didn't move the duplicate class `TestHelpers.java` from parquet. I can directly use `Assertions.assertThatThrownBy` in those tests. But that will increase the diff size. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org