nastra commented on code in PR #8937:
URL: https://github.com/apache/iceberg/pull/8937#discussion_r1376027991
##########
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogCommitFailure.java:
##########
@@ -265,13 +256,10 @@ public void testSucceededCommitThrowsUnknownException() {
GlueTableOperations spyOps = Mockito.spy(ops);
commitAndThrowException(ops, spyOps);
breakFallbackCatalogCommitCheck(spyOps);
-
- AssertHelpers.assertThrows(
- "Should throw CommitStateUnknownException since the catalog check was
blocked",
- CommitStateUnknownException.class,
- "Datacenter on fire",
- () -> spyOps.commit(metadataV2, metadataV1));
-
+ Assertions.assertThatThrownBy(() -> spyOps.commit(metadataV2, metadataV1))
+ .as("Should throw CommitStateUnknownException since the catalog check
was blocked")
Review Comment:
not needed
##########
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogCommitFailure.java:
##########
@@ -236,12 +229,10 @@ public void
testFailedCommitThrowsUnknownExceptionWhenStatusCheckFails() {
GlueTableOperations spyOps = Mockito.spy(ops);
failCommitAndThrowException(spyOps);
breakFallbackCatalogCommitCheck(spyOps);
-
- AssertHelpers.assertThrows(
- "Should throw CommitStateUnknownException since the catalog check was
blocked",
- CommitStateUnknownException.class,
- "Datacenter on fire",
- () -> spyOps.commit(metadataV2, metadataV1));
+ Assertions.assertThatThrownBy(() -> spyOps.commit(metadataV2, metadataV1))
+ .as("Should throw CommitStateUnknownException since the catalog check
was blocked")
Review Comment:
not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]