wypoon commented on code in PR #6799:
URL: https://github.com/apache/iceberg/pull/6799#discussion_r1375148065
##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -157,11 +157,34 @@ public static ManifestWriter<DataFile>
write(PartitionSpec spec, OutputFile outp
*/
public static ManifestWriter<DataFile> write(
int formatVersion, PartitionSpec spec, OutputFile outputFile, Long
snapshotId) {
+ return write(formatVersion, spec, outputFile, snapshotId, null, null);
+ }
+
+ /**
+ * Create a new {@link ManifestWriter} for the given format version.
+ *
+ * @param formatVersion a target format version
+ * @param spec a {@link PartitionSpec}
+ * @param outputFile an {@link OutputFile} where the manifest will be written
+ * @param snapshotId a snapshot ID for the manifest entries, or null for an
inherited ID
+ * @param compressionCodec compression codec for the manifest file
+ * @param compressionLevel compression level of the compressionCodec
+ * @return a manifest writer
+ */
+ public static ManifestWriter<DataFile> write(
Review Comment:
@sumeetgajjar originally used a `Map` parameter for this , and @rdblue
commented that "we don't want to pass a map of properties around. That's
exposing too much where it doesn't need to be, and people tend to misuse
generic arguments like this."
What I propose to do then is to introduce a `ManifestWriter.Options` class
and use that here (instead of a `Map`). I'll also introduce a
`ManifestListWriter.Options` class and use that in `ManifestLists.write`. These
`Options` classes define what additional parameters are applicable and may be
set. If in future, additional parameters are needed, they can be added to these
`Options` classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
