ajantha-bhat commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1374098273
##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -400,8 +400,15 @@ public void
replaceTableViaTransactionThatAlreadyExistsAsView() {
.buildTable(viewIdentifier, SCHEMA)
.replaceTransaction()
.commitTransaction())
- .isInstanceOf(NoSuchTableException.class)
- .hasMessageStartingWith("Table does not exist: ns.view");
+ .satisfiesAnyOf(
+ throwable ->
+ assertThat(throwable)
+ .isInstanceOf(NoSuchTableException.class)
+ .hasMessageStartingWith("Table does not exist: ns.view"),
+ throwable ->
+ assertThat(throwable)
Review Comment:
Nessie throws `AlreadyExistsException` for a view in this case. Do we need
to wrap it up with `NoSuchTableException` for a table in this case to
generalize like other catalogs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
