Fokko commented on code in PR #88:
URL: https://github.com/apache/iceberg-python/pull/88#discussion_r1367786667
##########
tests/expressions/test_parser.py:
##########
@@ -166,3 +166,8 @@ def test_starts_with() -> None:
def test_not_starts_with() -> None:
assert NotStartsWith("foo", "data") == parser.parse("foo NOT LIKE 'data'")
+
+
+def test_with_function() -> None:
+ with pytest.raises(ParseException):
+ parser.parse("foo = 1 and lower(bar) = '2")
Review Comment:
Always good to check the exception as well:
```suggestion
with pytest.raises(ParseException) as exc_info:
parser.parse("foo = 1 and lower(bar) = '2'")
assert "Expected end of text, found 'and'" in str(exc_info)
```
I also noticed that there is a `'` missing at the end, was this intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
