bknbkn commented on PR #8868: URL: https://github.com/apache/iceberg/pull/8868#issuecomment-1771963125
> Not sure I understand this change. Seems like you are removing an optimization to avoid re computing whether a path is deleted if we already determined it is deleted? In the original code, the `deletePath.add()` function is called regardless of whether the path is already in the `deletePath` set. I think it only needs to be called when the path is not in the `deletePath` set, if the path is already in the `deletePath` set, calling the `deletePath.add()` function will add nothing and is also unnecessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
