nk1506 commented on issue #8698: URL: https://github.com/apache/iceberg/issues/8698#issuecomment-1770264064
As part of this I have couple of questions ? For IcebergTable we use TableType as [EXTERNAL_TABLE](https://github.com/apache/hive/blob/b02cef4fe943b9aba597dcdfd3b8f3d3a5efca3e/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/TableType.java#L26) as well as properties with [TABLE_TYPE_PROP](https://github.com/apache/iceberg/blob/16c2af49a142d7044b619403de3e52aed13893e0/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java#L413). With View Support: 1. We can set TableType as [VIRTUAL_VIEW](https://github.com/apache/hive/blob/b02cef4fe943b9aba597dcdfd3b8f3d3a5efca3e/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/TableType.java#L27) 2. It will make implementation more clean. 3. We can also follow the strategy of managing extra field with table properties. 4. To make backward compatibility we must add the required checks every where. 5. [IMetaStoreClient](https://github.com/apache/hive/blob/b02cef4fe943b9aba597dcdfd3b8f3d3a5efca3e/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java#L654) doesn't have specific APIs for Views. 6. HiveTableOperations/HiveViewOperations must add all the required checks to manage same table/view name. Please share your thoughts. CC: @ajantha-bhat , @jbonofre . Also tag the relevant people. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
