zhangminglei commented on code in PR #8844:
URL: https://github.com/apache/iceberg/pull/8844#discussion_r1364968054
##########
core/src/main/java/org/apache/iceberg/CatalogProperties.java:
##########
@@ -86,8 +86,8 @@ private CatalogProperties() {}
* <ul>
* <li>Zero - Cache entries expires only if it gets evicted due to memory
pressure from {@link
* #IO_MANIFEST_CACHE_MAX_TOTAL_BYTES} setting.
- * <li>Positive Values - Cache entries expire if not accessed via the
cache after this many
- * milliseconds
+ * <li>Positive Values - Cache entries expire after a fixed time period,
regardless of whether
+ * they are accessed via the cache during this time
Review Comment:
Correct, manifest cache use `weakKeys` and `softValue` to expire entries by
gc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]