singhpk234 commented on PR #8843: URL: https://github.com/apache/iceberg/pull/8843#issuecomment-1767000250
> It seems like a behavior change that would only be safe if the behavior is always the same when creating multiple credentials providers. checked the DEFAULT_CREDENTIALS_PROVIDER singleton supplied earlier, it will be same as that what we would be creating now via `DefaultCredentialsProvider.builder().build()` as far a creds looks up is concerned (no behaviour change), never the less we have been creating a new cred provider instance when ever we supply accessKey or accessKeyId via `StaticCredentialsProvider.create(AwsCreds)`. Considering all of above we should be good imho :) !! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
