nastra commented on code in PR #8804: URL: https://github.com/apache/iceberg/pull/8804#discussion_r1362428279
########## api/src/test/java/org/apache/iceberg/metrics/TestDefaultTimer.java: ########## @@ -101,14 +103,7 @@ public void closeableTimer() throws InterruptedException { @Test public void measureRunnable() { Timer timer = new DefaultTimer(TimeUnit.NANOSECONDS); - Runnable runnable = Review Comment: the goal here is actually to measure the duration of the `runnable`, so this isn't something that we want to replace with Awaitility -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org