nk1506 commented on code in PR #8852:
URL: https://github.com/apache/iceberg/pull/8852#discussion_r1362111563
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamingMonitorFunction.java:
##########
@@ -111,14 +113,19 @@ public void testConsumeWithoutStartSnapshotId() throws
Exception {
TestSourceContext sourceContext = new TestSourceContext(latch);
runSourceFunctionInTask(sourceContext, function);
- Assert.assertTrue(
- "Should have expected elements.", latch.await(WAIT_TIME_MILLIS,
TimeUnit.MILLISECONDS));
- Thread.sleep(1000L);
+ Awaitility.await()
Review Comment:
IMO, we should move this common part at one place.
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##########
@@ -98,9 +98,9 @@ protected List<Record> generateRecords(int numRecords, long
seed) {
return RandomGenericData.generate(schema(), numRecords, seed);
}
- protected void assertRecords(
- Table table, List<Record> expectedRecords, Duration interval, int
maxCount) throws Exception {
- SimpleDataUtil.assertTableRecords(table, expectedRecords, interval,
maxCount);
+ protected void assertRecords(Table table, List<Record> expectedRecords,
Duration interval)
Review Comment:
do we need this method? can't we replace with
`SimpleDataUtil.assertTableRecords(table, expectedRecords, interval);` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
