nastra commented on code in PR #8250:
URL: https://github.com/apache/iceberg/pull/8250#discussion_r1360824697
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/InternalRowWrapper.java:
##########
@@ -71,8 +77,12 @@ public <T> void set(int pos, T value) {
row.update(pos, value);
}
- private static BiFunction<InternalRow, Integer, ?> getter(DataType type) {
+ private static BiFunction<InternalRow, Integer, ?> getter(Type icebergType,
DataType type) {
Review Comment:
I'd probably just keep it `type` to cause less changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
