amogh-jahagirdar commented on code in PR #8597:
URL: https://github.com/apache/iceberg/pull/8597#discussion_r1355502745
##########
core/src/main/java/org/apache/iceberg/io/RollingFileWriter.java:
##########
@@ -127,9 +130,8 @@ private void closeCurrentWriter() {
if (currentFileRows == 0L) {
try {
io.deleteFile(currentFile.encryptingOutputFile());
- } catch (UncheckedIOException e) {
- // the file may not have been created, and it isn't worth failing
the job to clean up,
- // skip deleting
+ } catch (Exception e) {
Review Comment:
Sorry for the delay on review, I think it makes sense to widen the exception
for this case but if we really want to solve this for all cases I think we
would want to catch `Throwable` instead of `Exception`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
