ajantha-bhat commented on code in PR #8796:
URL: https://github.com/apache/iceberg/pull/8796#discussion_r1354369805
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##########
@@ -426,13 +426,26 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
return !threw;
}
+ /** @deprecated will be removed after 1.5.0 */
+ @Deprecated
public void commitTable(
TableMetadata base,
TableMetadata metadata,
String newMetadataLocation,
IcebergTable expectedContent,
ContentKey key)
throws NessieConflictException, NessieNotFoundException {
+ throw new UnsupportedOperationException(
Review Comment:
> shouldn't that continue to work until the code is being removed?
Yes. Added the functionality back now.
> I think this overload is not required at all. Since this is not being used
anywhere we can safely remove this.
This is public API, Hence we need to deprecate it before removing to alert
users. It can be used outside of Iceberg repo like Trino integration etc.
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##########
@@ -426,13 +426,26 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
return !threw;
}
+ /** @deprecated will be removed after 1.5.0 */
+ @Deprecated
public void commitTable(
TableMetadata base,
TableMetadata metadata,
String newMetadataLocation,
IcebergTable expectedContent,
ContentKey key)
throws NessieConflictException, NessieNotFoundException {
+ throw new UnsupportedOperationException(
Review Comment:
> shouldn't that continue to work until the code is being removed?
Yes. Added the functionality back now.
> I think this overload is not required at all. Since this is not being used
anywhere we can safely remove this.
This is public API, Hence we need to deprecate it before removing to alert
users. It can be used outside of Iceberg repo like Trino integration etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
