rdblue commented on PR #40: URL: https://github.com/apache/iceberg-python/pull/40#issuecomment-1756223971
I think overall this is ready. There's one bug where a missing record field produces a double `OptionWriter`, but it wouldn't actually result in bad data because the outer option will always select the `NULL` branch of the union. We should fix this, but I'm going to approve this to unblock it since everything else looks correct. Thanks for getting this working @Fokko! It's a clever way to support multiple format versions and I wouldn't be surprised if we ended up using it for the other language implementations as well! (Sorry I was slow to understand it and thanks for convincing me.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
