rdblue commented on code in PR #6884:
URL: https://github.com/apache/iceberg/pull/6884#discussion_r1350549932


##########
core/src/main/java/org/apache/iceberg/encryption/PlaintextEncryptionManager.java:
##########
@@ -18,26 +18,32 @@
  */
 package org.apache.iceberg.encryption;
 
-import java.nio.ByteBuffer;
 import org.apache.iceberg.io.InputFile;
 import org.apache.iceberg.io.OutputFile;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 public class PlaintextEncryptionManager implements EncryptionManager {
+  private static final EncryptionManager INSTANCE = new 
PlaintextEncryptionManager();
   private static final Logger LOG = 
LoggerFactory.getLogger(PlaintextEncryptionManager.class);
 
+  @Deprecated

Review Comment:
   We typically add comments that state when the method will be removed and 
what to use instead. You can search for `@deprecated` in Javadoc to see 
examples.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to