Fokko commented on code in PR #40:
URL: https://github.com/apache/iceberg-python/pull/40#discussion_r1349777115
##########
pyiceberg/avro/writer.py:
##########
@@ -49,58 +51,69 @@ def __repr__(self) -> str:
return f"{self.__class__.__name__}()"
+@dataclass(frozen=True)
class NoneWriter(Writer):
- def write(self, _: BinaryEncoder, __: Any) -> None:
- pass
+ def write(self, encoder: BinaryEncoder, __: Any) -> None:
+ encoder.write_int(0)
Review Comment:
You're right here. The `NoneWriter` can go completely. We don't have to
invoke the writer if we skip over an entry in the data schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
