Fokko commented on code in PR #278:
URL: https://github.com/apache/iceberg-docs/pull/278#discussion_r1348969309


##########
landing-page/content/common/multi-engine-support.md:
##########
@@ -66,10 +66,11 @@ Each engine version undergoes the following lifecycle 
stages:
 | ---------- | ------------------ | ----------------------- 
|------------------------| ------------------ |
 | 2.4        | End of Life        | 0.7.0-incubating        | 1.2.1            
      | 
[iceberg-spark-runtime-2.4](https://search.maven.org/remotecontent?filepath=org/apache/iceberg/iceberg-spark-runtime-2.4/1.2.1/iceberg-spark-runtime-2.4-1.2.1.jar)
 |
 | 3.0        | End of Life        | 0.9.0                   | 1.0.0            
      | 
[iceberg-spark-runtime-3.0_2.12](https://search.maven.org/remotecontent?filepath=org/apache/iceberg/iceberg-spark-runtime-3.0_2.12/1.0.0/iceberg-spark-runtime-3.0_2.12-1.0.0.jar)
 |
-| 3.1        | Deprecated         | 0.12.0                  | {{% 
icebergVersion %}} | 
[iceberg-spark-runtime-3.1_2.12](https://search.maven.org/remotecontent?filepath=org/apache/iceberg/iceberg-spark-runtime-3.1_2.12/{{%
 icebergVersion %}}/iceberg-spark-runtime-3.1_2.12-{{% icebergVersion %}}.jar) 
[1] |
-| 3.2        | Maintained         | 0.13.0                  | {{% 
icebergVersion %}} | 
[iceberg-spark-runtime-3.2_2.12](https://search.maven.org/remotecontent?filepath=org/apache/iceberg/iceberg-spark-runtime-3.2_2.12/{{%
 icebergVersion %}}/iceberg-spark-runtime-3.2_2.12-{{% icebergVersion %}}.jar) |
+| 3.1        | End of Life        | 0.12.0                  | 1.3.1            
      | 
[iceberg-spark-runtime-3.1_2.12](https://search.maven.org/remotecontent?filepath=org/apache/iceberg/iceberg-spark-runtime-3.1_2.12/1.3.1/iceberg-spark-runtime-3.1_2.12-1.3.1.jar)
 [1]                               |
+| 3.2        | Deprecated         | 0.13.0                  | {{% 
icebergVersion %}} | 
[iceberg-spark-runtime-3.2_2.12](https://search.maven.org/remotecontent?filepath=org/apache/iceberg/iceberg-spark-runtime-3.2_2.12/{{%
 icebergVersion %}}/iceberg-spark-runtime-3.2_2.12-{{% icebergVersion %}}.jar) |

Review Comment:
   Nice! Let's remove it from the repository soon, such a waste of CI.



##########
landing-page/content/common/release-notes.md:
##########
@@ -26,10 +26,10 @@ disableSidebar: true
 The latest version of Iceberg is [{{% icebergVersion 
%}}](https://github.com/apache/iceberg/releases/tag/apache-iceberg-{{% 
icebergVersion %}}).
 

Review Comment:
   Should we also add the new bundles to the list?
   
   ```
   * [{{% icebergVersion %}} aws-bundle 
Jar](https://search.maven.org/remotecontent?filepath=org/apache/iceberg/iceberg-aws-bundle/{{%
 icebergVersion %}}/iceberg-aws-bundle-{{% icebergVersion %}}.jar)
   * [{{% icebergVersion %}} gcp-bundle 
Jar](https://search.maven.org/remotecontent?filepath=org/apache/iceberg/iceberg-gcp-bundle/{{%
 icebergVersion %}}/iceberg-gcp-bundle-{{% icebergVersion %}}.jar)
   * [{{% icebergVersion %}} azure-bundle 
Jar](https://search.maven.org/remotecontent?filepath=org/apache/iceberg/iceberg-azure-bundle/{{%
 icebergVersion %}}/iceberg-azure-bundle-{{% icebergVersion %}}.jar)
   ```
   (tested the paths)



##########
docs/config.toml:
##########
@@ -24,6 +24,7 @@ home = [ "HTML", "RSS", "SearchIndex" ]
 [menu]
   versions = [
     { name = "latest", pre = "relative", url = "../latest", weight = 1 },
+    { name = "1.4.0", pre = "relative", url = "../1.4.0", weight = 987 },

Review Comment:
   ```suggestion
       { name = "1.4.0", pre = "relative", url = "../1.4.0", weight = 988 },
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to