shreyanshR7 commented on code in PR #8725: URL: https://github.com/apache/iceberg/pull/8725#discussion_r1348940705
########## flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamingMonitorFunction.java: ########## @@ -113,7 +114,7 @@ public void testConsumeWithoutStartSnapshotId() throws Exception { Assert.assertTrue( "Should have expected elements.", latch.await(WAIT_TIME_MILLIS, TimeUnit.MILLISECONDS)); - Thread.sleep(1000L); + Awaitility.await().atLeast(1, TimeUnit.SECONDS).until(() -> true); Review Comment: I am new to open source , will it be ok if i replace this with simply Awaitility.await() .atMost(WAIT_TIME_MILLIS, TimeUnit.MILLISECONDS) .pollInterval(100, TimeUnit.MILLISECONDS) .until(() -> latch.getCount() == 0); @nastra or suggest changes please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org