rdblue commented on PR #42: URL: https://github.com/apache/iceberg-python/pull/42#issuecomment-1749783634
I don't think that this is necessary and I think it also breaks future uses of the visitor. Despite the name, the visitor this updates doesn't actually perform pre-order traversal. It creates futures that can be called to produce the result of further processing. In Java, we call this the "custom order" visitor because you can use it for any order you want by calling the future at a different point. This PR changes to actual pre-order traversal. That's fine, but it means that you can't actually customize as much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
