rdblue commented on code in PR #7913:
URL: https://github.com/apache/iceberg/pull/7913#discussion_r1342187049
##########
core/src/main/java/org/apache/iceberg/catalog/BaseSessionCatalog.java:
##########
@@ -84,6 +86,11 @@ public TableBuilder buildTable(TableIdentifier ident, Schema
schema) {
return BaseSessionCatalog.this.buildTable(context, ident, schema);
}
+ @Override
+ public void initialize(String catalogName, Map<String, String> props) {
+ BaseSessionCatalog.this.initialize(catalogName, props);
Review Comment:
This would re-initialize the wrapped `SessionCatalog` so I don't think that
this is correct. Instead, this should throw an exception that complains about
attempting to initialize the catalog when the underlying session catalog has
been initialized.
When used through `RESTCatalog`, this is never called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
