aokolnychyi commented on code in PR #8685: URL: https://github.com/apache/iceberg/pull/8685#discussion_r1342153777
########## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SerializableTableWithSize.java: ########## @@ -49,6 +61,14 @@ public static Table copyOf(Table table) { } } + @Override + public void close() throws Exception { + if (serializationMarker == null) { + LOG.info("Releasing resources"); + io().close(); + } + } + public static class SerializableMetadataTableWithSize extends SerializableMetadataTable Review Comment: Good catch, I overlooked it does not extend the main class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org